[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replica
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replication |
Date: |
Thu, 1 Dec 2016 08:55:07 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 12/01/2016 12:06 AM, Zhang Chen wrote:
> We can call this qmp command to start/stop replication outside of qemu.
> Like Xen colo need this function.
>
> Signed-off-by: Zhang Chen <address@hidden>
> Signed-off-by: Wen Congyang <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -4676,6 +4676,24 @@
> { 'command': 'xen-load-devices-state', 'data': {'filename': 'str'} }
>
> ##
> +# @xen-set-replication
> +#
> +# Enable or disable replication
> +#
> +# @enable: true to enable, false to disable.
> +#
> +# @primary: true for primary or false for secondary
> +#
> +# @failover: true to do failover, false to stop
Missing an #optional marker, as well as the default value.
> +#
> +# Returns: nothing
> +#
> +# Since: 2.8
You've missed 2.8. This must be 2.9.
> +##
> +{ 'command': 'xen-set-replication',
> + 'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
> +
> +##
> # @GICCapability:
> #
> # The struct describes capability for a specific GIC (Generic
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/3] Add new qmp commands to suppurt Xen COLO, Zhang Chen, 2016/12/01
- [Qemu-devel] [PATCH 1/3] Migration: Don't load vmdesc when xen is enabled, Zhang Chen, 2016/12/01
- [Qemu-devel] [PATCH 3/3] Add a new qmp command to do checkpoint, get replication error, Zhang Chen, 2016/12/01
- [Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replication, Zhang Chen, 2016/12/01
- Re: [Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replication,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 0/3] Add new qmp commands to suppurt Xen COLO, Stefano Stabellini, 2016/12/06