[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] Fix arm_semi_flen_cb for BE32 system mode.
From: |
Julian Brown |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] Fix arm_semi_flen_cb for BE32 system mode. |
Date: |
Tue, 6 Dec 2016 15:11:54 +0000 |
On Fri, 4 Nov 2016 10:00:19 +0100
Paolo Bonzini <address@hidden> wrote:
> On 03/11/2016 18:30, Julian Brown wrote:
> > +#ifdef CONFIG_USER_ONLY
> > size = be32_to_cpu(size);
> > +#else
> > + /* If we're running in BE32 system mode, we don't need to do
> > an explicit
> > + * byte swap, because (I think) target memory is already
> > stored in
> > + * byte-swapped format.
>
> Isn't this true also of user-mode (both BE8 and BE32)?
I'm not sure, I don't think the "load-time" byteswapping affects user
mode in the same way. Anyway, this can be refactored as attached, which
looks a bit more plausible perhaps.
Thanks,
Julian
0004-Fix-arm_semi_flen_cb-for-BE32-system-mode.patch
Description: Text Data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 3/5] Fix arm_semi_flen_cb for BE32 system mode.,
Julian Brown <=