[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/54] char: fold single-user functions in calle
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/54] char: fold single-user functions in caller |
Date: |
Wed, 14 Dec 2016 10:05:11 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 12/12/2016 04:42 PM, Marc-André Lureau wrote:
> This shorten a bit the code.
Grammar:
This shortens the code a bit.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> qemu-char.c | 97
> ++++++++++++++++++++-----------------------------------------
> 1 file changed, 31 insertions(+), 66 deletions(-)
>
> name = g_strdup_printf("chardev-udp-%s", chr->label);
> qio_channel_set_name(QIO_CHANNEL(sioc), name);
> g_free(name);
>
> + s = g_new0(NetCharDriver, 1);
> + s->ioc = QIO_CHANNEL(sioc);
> + s->bufcnt = 0;
> + s->bufptr = 0;
> + chr->opaque = s;
> + /* be isn't opened until we get a connection */
> + *be_opened = false;
The assignments to 0 and false are redundant with the g_new0(), if you
want to drop them for even more code reduction.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 01/54] gtk: avoid oob array access, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 02/54] char: use a const CharDriver, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 03/54] char: use a static array for backends, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 05/54] char: fold single-user functions in caller, Marc-André Lureau, 2016/12/12
- Re: [Qemu-devel] [PATCH 05/54] char: fold single-user functions in caller,
Eric Blake <=
- [Qemu-devel] [PATCH 04/54] char: move callbacks in CharDriver, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 06/54] char: introduce generic qemu_chr_get_kind(), Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 07/54] char: use a feature bit for replay, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 09/54] bt: use qemu_chr_alloc(), Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 08/54] char: allocate CharDriverState as a single object, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 11/54] char: rename TCPChardev and NetChardev, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 12/54] spice-char: improve error reporting, Marc-André Lureau, 2016/12/12