[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] audio: ac97: add exit function
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v2] audio: ac97: add exit function |
Date: |
Wed, 14 Dec 2016 19:06:45 +0000 |
Hi
On Wed, Dec 14, 2016 at 6:03 AM Li Qiang <address@hidden> wrote:
From: Li Qiang <address@hidden>
Currently the ac97 device emulation doesn't have a exit function,
hot unplug this device will leak some memory. Add a exit function to
avoid this.
Signed-off-by: Li Qiang <address@hidden>
---
Changes since the v1:
close the streams
hw/audio/ac97.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
index cbd959e..efa20b5 100644
--- a/hw/audio/ac97.c
+++ b/hw/audio/ac97.c
@@ -1387,6 +1387,23 @@ static void ac97_realize(PCIDevice *dev, Error
**errp)
ac97_on_reset (&s->dev.qdev);
}
+static void ac97_exit(PCIDevice *dev)
+{
+ AC97LinkState *s = DO_UPCAST(AC97LinkState, dev, dev);
+
+ if (s->voice_pi) {
+ AUD_close_in (&s->card, s->voice_pi);
+ }
+ if (s->voice_po) {
+ AUD_close_out (&s->card, s->voice_po);
+ }
+ if (s->voice_mc) {
+ AUD_close_in (&s->card, s->voice_mc);
+ }
+
You don't need to check if the pointer is non-null, same for es1370
Regarding style (space before parentheses), I think it's best to use qemu
style (no space), even if the file uses its own style.
+ AUD_remove_card (&s->card);
+}
+
static int ac97_init (PCIBus *bus)
{
pci_create_simple (bus, -1, "AC97");
@@ -1404,6 +1421,7 @@ static void ac97_class_init (ObjectClass *klass, void
*data)
PCIDeviceClass *k = PCI_DEVICE_CLASS (klass);
k->realize = ac97_realize;
+ k->exit = ac97_exit;
k->vendor_id = PCI_VENDOR_ID_INTEL;
k->device_id = PCI_DEVICE_ID_INTEL_82801AA_5;
k->revision = 0x01;
--
1.8.3.1
--
Marc-André Lureau