Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault

[Stefan Hajnoczi]

On Thu, Dec 15, 2016 at 09:47:38AM +0100, Kevin Wolf wrote:
> Am 14.12.2016 um 23:49 hat Michael S. Tsirkin geschrieben:
> > On Wed, Dec 14, 2016 at 02:25:18PM +0000, Stefan Hajnoczi wrote:
> > > The "Copy" menu item copies VTE terminal text to the clipboard.  This
> > > only works with VTE terminals, not with graphics consoles.
> > > 
> > > Disable the menu item when the current notebook page isn't a VTE
> > > terminal.
> > > 
> > > This patch fixes a segfault.  Reproducer: Start QEMU and click the Copy
> > > menu item when the guest display is visible.
> > > 
> > > Reported-by: Kevin Wolf <address@hidden>
> > > Cc: Michael S. Tsirkin <address@hidden>
> > > Cc: Gerd Hoffmann <address@hidden>
> > > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > 
> > I don't think it's 2.8 personally, patch just disables an
> > illegal action. Similar to the hotplug crash fix I
> > have queued. Just document this as a known issue.
> 
> This is an immediate crash for selecting a menu entry in the default
> view (which means killing a VM accidentally), we know the patch to fix
> it, and it is really small. Why would we not merge something like this?
> Are we making intentionally shitty releases these days?
> 
> I don't know your hotplug problem, but if it's a crash that isn't a
> real corner case, that suggests that it should have been fixed. I mean,
> fixing bugs is exactly what the freeze is for.

A lot of patches are queued waiting for the 2.9 development cycle,
including bug fixes.  The reason these bug fixes aren't merged for 2.8
is because they are not release blockers and they risk introducing new
regressions.

A line must be drawn somewhere since we cannot keep delaying the release
another week while possibly introducing new regressions.

I have asked everyone, including Michael, to send only clear release
blockers (i.e. regressions, build failures, critical bugs) even if they
wanted to include more bug fixes.  I can understand that he's now
wondering why I merged this patch in -rc4.

Is this patch a regression fix?  No
Is it a build fix? No
Is it a critical bug?  Probably not since no one noticed it in 2.7.

I merged it because I misinterpreted git log output and thought it was a
regression :).

In any case, we've reached the point where nothing more goes into the
tree so that QEMU 2.8.0 can be released.

Stefan

signature.asc
Description: PGP signature