qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RISU PATCH v3 02/10] aarch64: add hand-coded risu skel


From: Peter Maydell
Subject: Re: [Qemu-devel] [RISU PATCH v3 02/10] aarch64: add hand-coded risu skeleton for directed testing
Date: Fri, 16 Dec 2016 18:33:16 +0000

On 9 December 2016 at 11:48, Alex Bennée <address@hidden> wrote:
> Sometimes you want absolute control over your test set-up to feed
> explicit values into the test. This started as an experiment but might
> be useful for further developing tests.
>
> Signed-off-by: Alex Bennée <address@hidden>

I really don't like this patch, I'm afraid. I'd rather not have
it in the tree, because it implies that we expect that people
might want to write (or contribute back to us) handcoded test cases.
I don't think we should be encouraging that at all.

I only wrote the test_i386.s and test_arm.s originally because I hadn't
yet written the risugen script and wanted to test the C code I'd written.
Perhaps we should delete them now as being obsolete...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]