[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID |
Date: |
Tue, 20 Dec 2016 15:04:11 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
611c93d qmp/hmp: add set-vm-generation-id commands
4715fed qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands
9fbce29 ACPI: Add Virtual Machine Generation ID support
dbe5029 ACPI: Add a function for building named qword entries
4875862 docs: vm generation id device's description
=== OUTPUT BEGIN ===
Checking PATCH 1/5: docs: vm generation id device's description...
Checking PATCH 2/5: ACPI: Add a function for building named qword entries...
Checking PATCH 3/5: ACPI: Add Virtual Machine Generation ID support...
ERROR: space required after that ',' (ctx:VxV)
#131: FILE: hw/acpi/vmgenid.c:79:
+ aml_append(method,aml_store(aml_and(aml_name("VGIA"),
^
ERROR: code indent should never use tabs
#207: FILE: hw/acpi/vmgenid.c:155:
+ .parent^I = TYPE_SYS_BUS_DEVICE,$
total: 2 errors, 0 warnings, 266 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/5: qmp/hmp: add query-vm-generation-id and 'info
vm-generation-id' commands...
Checking PATCH 5/5: qmp/hmp: add set-vm-generation-id commands...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID, ben, 2016/12/19
- [Qemu-devel] [PATCH 1/5] docs: vm generation id device's description, ben, 2016/12/19
- [Qemu-devel] [PATCH 4/5] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands, ben, 2016/12/19
- [Qemu-devel] [PATCH 5/5] qmp/hmp: add set-vm-generation-id commands, ben, 2016/12/19
- [Qemu-devel] [PATCH 3/5] ACPI: Add Virtual Machine Generation ID support, ben, 2016/12/19
- [Qemu-devel] [PATCH 2/5] ACPI: Add a function for building named qword entries, ben, 2016/12/19
- Re: [Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID,
no-reply <=