[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] memory: hmp: dump flat view for 'info mtree
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] memory: hmp: dump flat view for 'info mtree' |
Date: |
Wed, 21 Dec 2016 15:56:11 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Dec 19, 2016 at 10:10:23PM +0800, Peter Xu wrote:
> Dumping flat view will be useful to debug the memory rendering logic,
> also it'll be much easier with it to know what memory region is handling
> what address range.
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> memory.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/memory.c b/memory.c
> index 5dcc2e1..a9154aa 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -2545,6 +2545,36 @@ static void mtree_print_mr(fprintf_function
> mon_printf, void *f,
> }
> }
>
> +static void mtree_print_flatview(fprintf_function p, void *f,
> + AddressSpace *as)
> +{
> + FlatView *view = address_space_get_flatview(as);
> + FlatRange *range = &view->ranges[0];
> + MemoryRegion *mr;
> + int n = view->nr;
> +
> + if (n <= 0) {
> + p(f, MTREE_INDENT "No rendered FlatView for "
> + "address space '%s'\n", as->name);
> + return;
> + }
> +
> + p(f, MTREE_INDENT "FlatView (address space '%s'):\n", as->name);
> +
> + while (n--) {
> + mr = range->mr;
> + p(f, MTREE_INDENT MTREE_INDENT TARGET_FMT_plx "-"
> + TARGET_FMT_plx " (prio %d, %c%c): %s\n",
> + int128_get64(range->addr.start),
> + int128_get64(range->addr.start) + MR_SIZE(mr->size),
^^^^^^^^
here it should be range->addr.size
Will repost. Thanks,
-- peterx