[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/5] display: virtio-gpu-3d: check virgl capabilities
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 1/5] display: virtio-gpu-3d: check virgl capabilities max_size |
Date: |
Tue, 3 Jan 2017 15:52:30 +0100 |
From: Prasad J Pandit <address@hidden>
Virtio GPU device while processing 'VIRTIO_GPU_CMD_GET_CAPSET'
command, retrieves the maximum capabilities size to fill in the
response object. It continues to fill in capabilities even if
retrieved 'max_size' is zero(0), thus resulting in OOB access.
Add check to avoid it.
Reported-by: Zhenhao Hong <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/display/virtio-gpu-3d.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
index 23f39de..e29f099 100644
--- a/hw/display/virtio-gpu-3d.c
+++ b/hw/display/virtio-gpu-3d.c
@@ -371,8 +371,12 @@ static void virgl_cmd_get_capset(VirtIOGPU *g,
virgl_renderer_get_cap_set(gc.capset_id, &max_ver,
&max_size);
+ if (!max_size) {
+ cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER;
+ return;
+ }
+
resp = g_malloc(sizeof(*resp) + max_size);
-
resp->hdr.type = VIRTIO_GPU_RESP_OK_CAPSET;
virgl_renderer_fill_caps(gc.capset_id,
gc.capset_version,
--
1.8.3.1
- [Qemu-devel] [PULL 0/5] virtio-gpu: misc bugfixes., Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 1/5] display: virtio-gpu-3d: check virgl capabilities max_size,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 2/5] virtio-gpu: track and limit host memory allocations, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 5/5] virtio-gpu: fix memory leak in resource attach backing, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 3/5] virtio-gpu: call cleanup mapping function in resource destroy, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 4/5] virtio-gpu-3d: fix memory leak in resource attach backing, Gerd Hoffmann, 2017/01/03
- Re: [Qemu-devel] [PULL 0/5] virtio-gpu: misc bugfixes., Peter Maydell, 2017/01/05