[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/13] 9pfs: fix P9_NOTAG and P9_NOFID macros
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PULL 08/13] 9pfs: fix P9_NOTAG and P9_NOFID macros |
Date: |
Wed, 4 Jan 2017 09:21:42 +0100 |
The u16 and u32 types don't exist in QEMU common headers. It never broke
build because these two macros aren't use by the current code, but this
is about to change with the future addition of functional tests for 9P.
Also, these should have enclosing parenthesis to be usable in any
syntactical situation.
As suggested by Eric Blake, let's use UINT16_MAX and UINT32_MAX to address
both issues.
Signed-off-by: Greg Kurz <address@hidden>
---
hw/9pfs/9p.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h
index 4c4feafa2e97..b7e836251e13 100644
--- a/hw/9pfs/9p.h
+++ b/hw/9pfs/9p.h
@@ -99,8 +99,8 @@ enum p9_proto_version {
V9FS_PROTO_2000L = 0x02,
};
-#define P9_NOTAG (u16)(~0)
-#define P9_NOFID (u32)(~0)
+#define P9_NOTAG UINT16_MAX
+#define P9_NOFID UINT32_MAX
#define P9_MAXWELEM 16
#define FID_REFERENCED 0x1
--
2.7.4
- [Qemu-devel] [PULL 00/13] 9p patches 20170104, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 03/13] 9pfs: call v9fs_init_qiov_from_pdu before v9fs_pack, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 01/13] 9pfs: move pdus to V9fsState, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 02/13] 9pfs: introduce transport specific callbacks, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 05/13] 9pfs: fix crash when fsdev is missing, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 06/13] tests: virtio-9p: rename PCI configuration test, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 04/13] 9pfs: introduce init_out/in_iov_from_pdu, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 07/13] tests: virtio-9p: code refactoring, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 08/13] 9pfs: fix P9_NOTAG and P9_NOFID macros,
Greg Kurz <=
- [Qemu-devel] [PULL 11/13] tests: virtio-9p: add walk operation test, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 10/13] tests: virtio-9p: add attach operation test, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 12/13] tests: virtio-9p: no slash in path elements during walk, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 09/13] tests: virtio-9p: add version operation test, Greg Kurz, 2017/01/04
- [Qemu-devel] [PULL 13/13] tests: virtio-9p: ".." cannot be used to walk out of the shared directory, Greg Kurz, 2017/01/04
- Re: [Qemu-devel] [PULL 00/13] 9p patches 20170104, Peter Maydell, 2017/01/05