Re: [Qemu-devel] [PATCH] win32: use glib gpoll if glib >= 2.50

[Daniel P. Berrange]

On Tue, Jan 03, 2017 at 08:19:33PM +0100, Marc-André Lureau wrote:
> A fix has been committed in upstream glib commit
> 210a9796f78eb90f76f1bd6a304e9fea05e97617.
> (See also related bug https://bugzilla.gnome.org/show_bug.cgi?id=764415)

The bug is a little misleading because the comments indicate that
patch was going to be merged to master after 2.50 branched. The
git commit hash though shows it merged before branching

$ git describe 210a9796f78eb90f76f1bd6a304e9fea05e97617
2.48.0-41-g210a979

so the >= 2.50 check is good.

> It is desirable to use the glib version instead of qemu copy, since it
> provides more debugging facilities (G_MAIN_POLL_DEBUG etc), and
> hopefully has a better maintainance. Hopefully, we can drop the qemu
> copy in a few years.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  include/glib-compat.h | 2 +-
>  util/oslib-win32.c    | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrange <address@hidden>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|