Re: [Qemu-devel] [PATCH 3/3] nbd: do not block on partial reply header reads

[Eric Blake]

On 12/23/2016 12:26 PM, Paolo Bonzini wrote:
> Read the replies from a coroutine.  qio_channel_yield is used so that
> the right coroutine is restarted automatically, eliminating the need
> for send_coroutine in NBDClientSession.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  block/nbd-client.c | 108 
> +++++++++++++++++++++--------------------------------
>  1 file changed, 42 insertions(+), 66 deletions(-)
> 

Looks like a nice simplification. I'm not quite confident enough of my
understanding of coroutines to give R-b yet, but I can certainly try and
play with the patches to provide some test results (especially since
this series still depends on others being reviewed).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature