Re: [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify

[Marc-André Lureau]

Hi

On Mon, Jan 2, 2017 at 11:27 AM Paolo Bonzini <address@hidden> wrote:

>
>
> On 12/12/2016 23:42, Marc-André Lureau wrote:
> >
> > Note: this series has been tested with Linux and cross-building with
> > mingw. It mostly breaks on other platforms,
>
> What breaks exactly?
>
>
Not much that I know. I was afraid it would break on BSD (in particular the
move to own file and last patch), so I tested on FreeBSD. The last version
of the series works on win32, linux and freebsd. It can be found on
https://github.com/elmarco/qemu/commits/chrfe It's slightly over 80 patches
now, and needs some win32 fixes I sent earlier (subprocess tests, and
main-loop busy loop fix)

Since Erik started reviewing the series, I suggest to resend the first part
until "qom-ify" patch. Erik, feel free to review the remaining part of the
WIP series, but more changes happened after iirc. What do you think?


Paolo
>
> > help welcome for
> > testing. I'd also like to write more chardev backend tests to ensure
> > no regression (test-char.c is quite limited for now)
>
> --
Marc-André Lureau