Re: [Qemu-devel] [PATCH 2/8] io: stop incrementing reference in qio_task_get_source

[Eric Blake]

On 01/05/2017 10:03 AM, Daniel P. Berrange wrote:
> Incrementing the reference in qio_task_get_source is
> not neccessary, since we're not running concurrently

s/neccessary/necessary/

> with any other code touching the QIOTask. This
> minimizes chances of further memory leaks.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  include/io/task.h    | 7 ++++---
>  io/channel-socket.c  | 3 ---
>  io/channel-tls.c     | 2 --
>  io/task.c            | 1 -
>  tests/test-io-task.c | 1 -
>  5 files changed, 4 insertions(+), 10 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature