Re: [Qemu-devel] [PATCH v2 4/6] ARM big-endian system-mode gdbstub support.

[Peter Maydell]

On 7 December 2016 at 14:49, Julian Brown <address@hidden> wrote:
> When debugging a big-endian (either BE8 or BE32) executable, GDB uses
> a big-endian byte ordering for its remote protocol.  The gdb stub
> code in QEMU needs to interpret data in host (little-endian) order in
> arm_cpu_gdb_read_register and arm_cpu_gdb_write_register, so this patch
> arranges to byte-swap the data to/from GDB in those cases.
>
> Signed-off-by: Julian Brown <address@hidden>
> ---
>  target-arm/gdbstub.c | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)

More compile errors:

In file included from
/home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/gdbstub.c:24:0:
/home/petmay01/linaro/qemu-from-laptop/qemu/include/exec/softmmu-arm-semi.h:106:14:
error: ‘softmmu_lock_user’ defined but not used
[-Werror=unused-function]
 static void *softmmu_lock_user(CPUArchState *env,
              ^
/home/petmay01/linaro/qemu-from-laptop/qemu/include/exec/softmmu-arm-semi.h:118:14:
error: ‘softmmu_lock_user_string’ defined but not used
[-Werror=unused-function]
 static char *softmmu_lock_user_string(CPUArchState *env, target_ulong addr)
              ^
In file included from
/home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/gdbstub.c:24:0:
/home/petmay01/linaro/qemu-from-laptop/qemu/include/exec/softmmu-arm-semi.h:136:13:
error: ‘softmmu_unlock_user’ defined but not used
[-Werror=unused-function]
 static void softmmu_unlock_user(CPUArchState *env, void *p, target_ulong addr,
             ^

Missing "inline"s, I think.

thanks
-- PMM