[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular tra
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular trace.h file |
Date: |
Fri, 6 Jan 2017 17:23:11 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, Jan 06, 2017 at 09:02:42AM -0800, address@hidden wrote:
> Hi,
>
> Your series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce
> it
[snip]
> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_update’:
> /tmp/qemu-test/src/hw/char/pl011.c:62: warning: implicit declaration of
> function ‘trace_pl011_irq_state’
> /tmp/qemu-test/src/hw/char/pl011.c:62: warning: nested extern declaration of
> ‘trace_pl011_irq_state’
> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_read’:
> /tmp/qemu-test/src/hw/char/pl011.c:87: warning: implicit declaration of
> function ‘trace_pl011_read_fifo’
> /tmp/qemu-test/src/hw/char/pl011.c:87: warning: nested extern declaration of
> ‘trace_pl011_read_fifo’
> /tmp/qemu-test/src/hw/char/pl011.c:139: warning: implicit declaration of
> function ‘trace_pl011_read’
> /tmp/qemu-test/src/hw/char/pl011.c:139: warning: nested extern declaration of
> ‘trace_pl011_read’
> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_write’:
> /tmp/qemu-test/src/hw/char/pl011.c:163: warning: implicit declaration of
> function ‘trace_pl011_write’
> /tmp/qemu-test/src/hw/char/pl011.c:163: warning: nested extern declaration of
> ‘trace_pl011_write’
> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_can_receive’:
> /tmp/qemu-test/src/hw/char/pl011.c:237: warning: implicit declaration of
> function ‘trace_pl011_can_receive’
> /tmp/qemu-test/src/hw/char/pl011.c:237: warning: nested extern declaration of
> ‘trace_pl011_can_receive’
> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_put_fifo’:
> /tmp/qemu-test/src/hw/char/pl011.c:252: warning: implicit declaration of
> function ‘trace_pl011_put_fifo’
> /tmp/qemu-test/src/hw/char/pl011.c:252: warning: nested extern declaration of
> ‘trace_pl011_put_fifo’
> /tmp/qemu-test/src/hw/char/pl011.c:254: warning: implicit declaration of
> function ‘trace_pl011_put_fifo_full’
> /tmp/qemu-test/src/hw/char/pl011.c:254: warning: nested extern declaration of
> ‘trace_pl011_put_fifo_full’
Sigh, include search path ordering is different when doing in-tree vs
out of tree builds.
When in-tree, the headers in the hw/char sub-dir are found *before*
the top level source dir.
When out of tree, the headers hw/char *build* dir are found *after*
the top level source dir.
Will have to investigate how we can fix the include ordering.
This is also a sign that travis.yml should do at least one of its
builds with srcdir != build dir
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
- [Qemu-devel] [PATCH v2 46/47] trace: update docs to reflect new code generation approach, (continued)
- [Qemu-devel] [PATCH v2 46/47] trace: update docs to reflect new code generation approach, Daniel P. Berrange, 2017/01/06
- [Qemu-devel] [PATCH v2 47/47] trace: improve error reporting when parsing simpletrace header, Daniel P. Berrange, 2017/01/06
- [Qemu-devel] [PATCH v2 45/47] trace: remove the global include/trace.h file, Daniel P. Berrange, 2017/01/06
- [Qemu-devel] [PATCH v2 43/47] trace: switch linux-user/ directory to modular trace.h file, Daniel P. Berrange, 2017/01/06
- Re: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular trace.h file, Daniel P. Berrange, 2017/01/06
- Re: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular trace.h file, no-reply, 2017/01/06
- Re: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular trace.h file,
Daniel P. Berrange <=