[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support |
|
Date: |
Mon, 9 Jan 2017 09:03:29 +0000 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Fam Zheng (address@hidden) wrote:
> On Fri, 01/06 18:59, Dr. David Alan Gilbert wrote:
> > * address@hidden (address@hidden) wrote:
> > > Hi,
> > > Checking PATCH 14/15: postcopy: Check for userfault+hugepage feature...
> > > ERROR: trailing whitespace
> > > #21: FILE: migration/postcopy-ram.c:85:
> > > + bool have_hp = false; $
> >
> > I noticed that one but explicitly left it; the code really reads much
> > more cleanly to me with it explicitly set.
>
> It's not complaining about the variable being initialized, but rather the
> ending
> whitespace before EOL.
Oops! Yeh that I need to fix.
(And read the messages!)
Dave
> Fam
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 09/15] postcopy: Load huge pages in one go, (continued)
- [Qemu-devel] [PATCH 10/15] postcopy: Mask fault addresses to huge page boundary, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 11/15] postcopy: Send whole huge pages, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 12/15] postcopy: Allow hugepages, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 13/15] postcopy: Update userfaultfd.h header, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 14/15] postcopy: Check for userfault+hugepage feature, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 15/15] postcopy: Add doc about hugepages and postcopy, Dr. David Alan Gilbert (git), 2017/01/06
- Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support, no-reply, 2017/01/06
- Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support, no-reply, 2017/01/06