Re: [Qemu-devel] [PATCH v4] [i.MX] fix CS handling during SPI access.

[Peter Maydell]

On 9 January 2017 at 19:04, mar.krzeminski <address@hidden> wrote:
>
>
> W dniu 09.01.2017 o 11:46, Peter Maydell pisze:
>> Calling qemu_set_irq() in a device reset function is a bit
>> tricky, because in a full system reset the device at the other
>> end might have already reset or might not, and calling into
>> its handler function for the irq line change might provoke
>> an unwanted change of its state. We don't really have a coherent
>> model here but for the moment we just try to avoid calling
>> set_irq in a reset method.
>
> JC, if you remove qemu_set_irq() call from reset, at least m25p80 behavior
> should not change since m25p80 reset handler will reset it's whole internal
> state.

I noticed the reset function is also called from within the
register emulation too, so it's maybe not quite that simple...

thanks
-- PMM