Re: [Qemu-devel] [PULL 00/33] Misc patches for 2017-01-11

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/33] Misc patches for 2017-01-11

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
cf0576e Revert "win32: don't run subprocess tests on Mingw32 platform"
c85fbfe hax: add Darwin support
21832a0 Plumb the HAXM-based hardware acceleration support
330afce target/i386: Add Intel HAX files
baf1a22 kvm: move cpu synchronization code
f56412d ramblock-notifier: new
b5dd27b char: fix ctrl-a b not working
bd01773 exec: Add missing rcu_read_unlock
6084927 x86: ioapic: fix fail migration when irqchip=split
d0785ae x86: ioapic: dump version for "info ioapic"
b7ed2ee x86: ioapic: add traces for ioapic
d4068a3 hxtool: emit Texinfo headings as @subsection
529805f qemu-thread: fix qemu_thread_set_name() race in qemu_thread_create()
7842a04 serial: fix memory leak in serial exit
3bf3b10 scsi-block: fix direction of BYTCHK test for VERIFY commands
60426db pc: fix crash in rtc_set_memory() if initial cpu is marked as hotplugged
95f96f3 target-i386: Correctly apply patch for syscall eflags.TF handling
4638021 acpi: filter based on CONFIG_ACPI_X86 rather than TARGET
99dea51 stubs: remove stubs/kvm.c
2990774 build: remove --enable-colo/--disable-colo
ff393df event_notifier: cleanups around event_notifier_set_handler
7add0ff stubs: move vhost stubs to stubs/vhost.o
ece88a5 stubs: group all monitor_fdset_* functions in a single file
5867420 stubs: group stubs for user-mode emulation
d86b1eb hw: move reset handlers from vl.c to hw/core
b06a0c1 stubs: remove unused stub for serial_hd
141d390 stubs: move acpi stubs to hw/acpi
faa6ee0 stubs: move smbios stubs to hw/smbios
e28f337 stubs: merge all monitor stubs in one file, remove monitor_cur_is_qmp 
stub
ba95497 smbios: filter based on CONFIG_SMBIOS rather than TARGET
a4feba7 qom: Make all interface types abstract
a65e049 megasas: fix guest-triggered memory leak
38a291f bugfix: vm halt when in reset looping

=== OUTPUT BEGIN ===
Checking PATCH 1/33: bugfix: vm halt when in reset looping...
Checking PATCH 2/33: megasas: fix guest-triggered memory leak...
Checking PATCH 3/33: qom: Make all interface types abstract...
WARNING: line over 80 characters
#132: FILE: tests/device-introspect-test.c:174:
+    qtest_add_func("device/introspect/abstract-interfaces", 
test_abstract_interfaces);

total: 0 errors, 1 warnings, 105 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/33: smbios: filter based on CONFIG_SMBIOS rather than TARGET...
Checking PATCH 5/33: stubs: merge all monitor stubs in one file, remove 
monitor_cur_is_qmp stub...
ERROR: do not initialise globals to 0 or NULL
#76: FILE: stubs/monitor.c:6:
+Monitor *cur_mon = NULL;

total: 1 errors, 0 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/33: stubs: move smbios stubs to hw/smbios...
Checking PATCH 7/33: stubs: move acpi stubs to hw/acpi...
Checking PATCH 8/33: stubs: remove unused stub for serial_hd...
Checking PATCH 9/33: hw: move reset handlers from vl.c to hw/core...
Checking PATCH 10/33: stubs: group stubs for user-mode emulation...
Checking PATCH 11/33: stubs: group all monitor_fdset_* functions in a single 
file...
Checking PATCH 12/33: stubs: move vhost stubs to stubs/vhost.o...
Checking PATCH 13/33: event_notifier: cleanups around 
event_notifier_set_handler...
Checking PATCH 14/33: build: remove --enable-colo/--disable-colo...
Checking PATCH 15/33: stubs: remove stubs/kvm.c...
Checking PATCH 16/33: acpi: filter based on CONFIG_ACPI_X86 rather than 
TARGET...
Checking PATCH 17/33: target-i386: Correctly apply patch for syscall eflags.TF 
handling...
Checking PATCH 18/33: pc: fix crash in rtc_set_memory() if initial cpu is 
marked as hotplugged...
Checking PATCH 19/33: scsi-block: fix direction of BYTCHK test for VERIFY 
commands...
Checking PATCH 20/33: serial: fix memory leak in serial exit...
Checking PATCH 21/33: qemu-thread: fix qemu_thread_set_name() race in 
qemu_thread_create()...
Checking PATCH 22/33: hxtool: emit Texinfo headings as @subsection...
Checking PATCH 23/33: x86: ioapic: add traces for ioapic...
Checking PATCH 24/33: x86: ioapic: dump version for "info ioapic"...
Checking PATCH 25/33: x86: ioapic: fix fail migration when irqchip=split...
Checking PATCH 26/33: exec: Add missing rcu_read_unlock...
Checking PATCH 27/33: char: fix ctrl-a b not working...
Checking PATCH 28/33: ramblock-notifier: new...
Checking PATCH 29/33: kvm: move cpu synchronization code...
Checking PATCH 30/33: target/i386: Add Intel HAX files...
Checking PATCH 31/33: Plumb the HAXM-based hardware acceleration support...
Checking PATCH 32/33: hax: add Darwin support...
Checking PATCH 33/33: Revert "win32: don't run subprocess tests on Mingw32 
platform"...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden