[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] virtio: disable notifications again after p
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] virtio: disable notifications again after poll succeeded |
Date: |
Fri, 13 Jan 2017 17:53:05 +0200 |
On Thu, Jan 12, 2017 at 11:46:11AM +0000, Stefan Hajnoczi wrote:
> While AioContext is in polling mode virtqueue notifications are not
> necessary. Some device virtqueue handlers enable notifications. Make
> sure they stay disabled to avoid unnecessary vmexits.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
So I'll put just the revert in today's pull request,
let's make sure this one is not causing regressions.
> ---
> hw/virtio/virtio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index f04ab7a..34065c7 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -2126,6 +2126,9 @@ static bool virtio_queue_host_notifier_aio_poll(void
> *opaque)
> }
>
> virtio_queue_notify_aio_vq(vq);
> +
> + /* In case the handler function re-enabled notifications */
> + virtio_queue_set_notification(vq, 0);
> return true;
> }
>
> --
> 2.9.3
- [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Stefan Hajnoczi, 2017/01/12
- [Qemu-devel] [PATCH 1/2] Revert "virtio: turn vq->notification into a nested counter", Stefan Hajnoczi, 2017/01/12
- [Qemu-devel] [PATCH 2/2] virtio: disable notifications again after poll succeeded, Stefan Hajnoczi, 2017/01/12
- Re: [Qemu-devel] [PATCH 2/2] virtio: disable notifications again after poll succeeded,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Doug Goldstein, 2017/01/12
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Michael S. Tsirkin, 2017/01/12
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Stefan Hajnoczi, 2017/01/13
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Doug Goldstein, 2017/01/13
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Stefan Hajnoczi, 2017/01/16
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Doug Goldstein, 2017/01/16
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Michael S. Tsirkin, 2017/01/16
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Stefan Hajnoczi, 2017/01/17
Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Richard Henderson, 2017/01/13