Re: [Qemu-devel] [PATCH 06/16] nbd: do not block on partial reply header reads

[Paolo Bonzini]

On 16/01/2017 13:52, Fam Zheng wrote:
> +    /* Kick the read_reply_co to get the next reply.  */
> +    aio_co_wake(s->read_reply_co);
> 
> Can't s->read_reply_co be NULL? nbd_read_reply_entry unsets it. (Surprisingly
> this file is rather unfamiliar to me, it's possible I'm missing something.)

Yes, that can happen depending on how the coroutines are scheduled when
the server goes down.

Paolo