Re: [Qemu-devel] [PATCH] qtest: virtio: zeroed last VRingDesc after allocate

[Longpeng (Mike)]

Hi Stefan,

On 2017/1/16 22:13, Stefan Hajnoczi wrote:

> On Sat, Jan 14, 2017 at 05:59:36PM +0800, Longpeng(Mike) wrote:
......
>> diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c
>> index ec30cb9..b29c69e 100644
>> --- a/tests/libqos/virtio.c
>> +++ b/tests/libqos/virtio.c
>> @@ -171,12 +171,20 @@ QVRingIndirectDesc 
>> *qvring_indirect_desc_setup(QVirtioDevice *d,
>>      for (i = 0; i < elem - 1; ++i) {
>>          /* indirect->desc[i].addr */
>>          writeq(indirect->desc + (16 * i), 0);
>> +        /* indirect->desc[i].len */
>> +        writeq(indirect->desc + (16 * i) + 8, 0);
> 
> The len field is 32 bits long.  Please use writel().
> 
>>          /* indirect->desc[i].flags */
>>          writew(indirect->desc + (16 * i) + 12, VRING_DESC_F_NEXT);
>>          /* indirect->desc[i].next */
>>          writew(indirect->desc + (16 * i) + 14, i + 1);
>>      }
>>  
>> +    /* zeroed last element */
>> +    writeq(indirect->desc + (16 * i), 0); /* addr */
>> +    writeq(indirect->desc + (16 * i) + 8, 0); /*len*/
> 
> Same here.


OK. I will fix it in V2.

-- 
Regards,
Longpeng(Mike)