Re: [Qemu-devel] [PATCH 3/3] COLO: Don't process failover request while loading VM's state

[Hailiang Zhang]

On 2017/1/18 2:24, Eric Blake wrote:
> On 01/17/2017 06:57 AM, zhanghailiang wrote:
> > We should not do failover work while the main thread is loading
> > VM's state. Otherwise the consistent of VM's memory and
> > device state will be broken.
> >
> > We will restart the loading process after jump over the stage,
> > The new failover status 'RELAUNCH' will help to record if we
> > need to restart the process.
> >
> > Cc: Eric Blake <address@hidden>
> > Signed-off-by: zhanghailiang <address@hidden>
> > Signed-off-by: Li Zhijian <address@hidden>
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> >   migration/colo.c | 26 ++++++++++++++++++++++++++
> >   qapi-schema.json |  4 +++-
> >   2 files changed, 29 insertions(+), 1 deletion(-)
>
> > +++ b/qapi-schema.json
> > @@ -856,10 +856,12 @@
> >   #
> >   # @completed: finish the process of failover
> >   #
> > +# @relaunch: restart the failover process, from 'none' -> 'completed'
>
> You'll need to add a '(since 2.9)' tag

OK, I'll add it in next version, thanks.

> > +#
> >   # Since: 2.8
> >   ##
> >   { 'enum': 'FailoverStatus',
> > -  'data': [ 'none', 'require', 'active', 'completed'] }
> > +  'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] }
> >
> >   ##
> >   # @x-colo-lost-heartbeat: