[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/7] target-m68k: implement 680x0 FPU
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/7] target-m68k: implement 680x0 FPU |
Date: |
Wed, 18 Jan 2017 13:21:23 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/7] target-m68k: implement 680x0 FPU
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
aba9788 target-m68k: implements more FPU instructions
9ec3c4f target-m68k: introduce fscc.
a5d5dab target-m68k: add fmovem
1dc2042 target-m68k: use floatx80 internally
c202985 softfloat: define 680x0 specific values
e1de738 target-m68k: define ext_opsize
1cb012d target-m68k: move FPU helpers to fpu_helper.c
=== OUTPUT BEGIN ===
Checking PATCH 1/7: target-m68k: move FPU helpers to fpu_helper.c...
Checking PATCH 2/7: target-m68k: define ext_opsize...
Checking PATCH 3/7: softfloat: define 680x0 specific values...
Checking PATCH 4/7: target-m68k: use floatx80 internally...
ERROR: storage class should be at the beginning of the declaration
#849: FILE: target/m68k/translate.c:39:
+#define DEFF96(name, offset) static TCGv_i32 QREG_##name##H; \
total: 1 errors, 0 warnings, 1898 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/7: target-m68k: add fmovem...
Checking PATCH 6/7: target-m68k: introduce fscc....
Checking PATCH 7/7: target-m68k: implements more FPU instructions...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 0/7] target-m68k: implement 680x0 FPU, Laurent Vivier, 2017/01/18
- [Qemu-devel] [PATCH 2/7] target-m68k: define ext_opsize, Laurent Vivier, 2017/01/18
- [Qemu-devel] [PATCH 5/7] target-m68k: add fmovem, Laurent Vivier, 2017/01/18
- [Qemu-devel] [PATCH 1/7] target-m68k: move FPU helpers to fpu_helper.c, Laurent Vivier, 2017/01/18
- [Qemu-devel] [PATCH 3/7] softfloat: define 680x0 specific values, Laurent Vivier, 2017/01/18
- [Qemu-devel] [PATCH 7/7] target-m68k: implements more FPU instructions, Laurent Vivier, 2017/01/18
- [Qemu-devel] [PATCH 6/7] target-m68k: introduce fscc., Laurent Vivier, 2017/01/18
- [Qemu-devel] [PATCH 4/7] target-m68k: use floatx80 internally, Laurent Vivier, 2017/01/18
- Re: [Qemu-devel] [PATCH 0/7] target-m68k: implement 680x0 FPU,
no-reply <=
- Re: [Qemu-devel] [PATCH 0/7] target-m68k: implement 680x0 FPU, Richard Henderson, 2017/01/18