[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/4] ARRAY_SIZE fixups
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/4] ARRAY_SIZE fixups |
Date: |
Fri, 20 Jan 2017 07:15:57 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v3 0/4] ARRAY_SIZE fixups
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
86ed4e3 ARRAY_SIZE: check that argument is an array
6c5d1ef compiler: expression version of QEMU_BUILD_BUG_ON
650275f compiler: rework BUG_ON using a struct
593e31a compiler: drop ; after BUILD_BUG_ON
=== OUTPUT BEGIN ===
Checking PATCH 1/4: compiler: drop ; after BUILD_BUG_ON...
Checking PATCH 2/4: compiler: rework BUG_ON using a struct...
ERROR: spaces prohibited around that ':' (ctx:WxW)
#29: FILE: include/qemu/compiler.h:90:
+ int qemu_build_bug_on : (x) ? -1 : 1; \
^
total: 1 errors, 0 warnings, 15 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/4: compiler: expression version of QEMU_BUILD_BUG_ON...
Checking PATCH 4/4: ARRAY_SIZE: check that argument is an array...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v3 3/4] compiler: expression version of QEMU_BUILD_BUG_ON, (continued)
Re: [Qemu-devel] [PATCH v3 0/4] ARRAY_SIZE fixups, Markus Armbruster, 2017/01/20
Re: [Qemu-devel] [PATCH v3 0/4] ARRAY_SIZE fixups, no-reply, 2017/01/20
Re: [Qemu-devel] [PATCH v3 0/4] ARRAY_SIZE fixups,
no-reply <=