[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v1 1/8] sockets: add ability to disable DNS resolutio
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PULL v1 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress |
Date: |
Mon, 23 Jan 2017 14:26:22 +0000 |
Add a 'numeric' flag to the InetSocketAddress struct to allow the
caller to indicate that DNS should be skipped for the host/port
fields. This is useful if the caller knows the address is already
numeric and wants to guarantee no (potentially blocking) DNS
lookups are attempted.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
---
qapi-schema.json | 5 +++++
util/qemu-sockets.c | 3 +++
2 files changed, 8 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index ddc8783..ac55f4a 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3983,6 +3983,10 @@
#
# @port: port part of the address, or lowest port if @to is present
#
+# @numeric: #optional true if the host/port are guaranteed to be numeric,
+# false if name resolution should be attempted. Defaults to false.
+# (Since 2.9)
+#
# @to: highest port to try
#
# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and IPv6
@@ -3997,6 +4001,7 @@
'data': {
'host': 'str',
'port': 'str',
+ '*numeric': 'bool',
'*to': 'uint16',
'*ipv4': 'bool',
'*ipv6': 'bool' } }
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index fe1d07a..d63b011 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -141,6 +141,9 @@ static int inet_listen_saddr(InetSocketAddress *saddr,
memset(&ai,0, sizeof(ai));
ai.ai_flags = AI_PASSIVE;
+ if (saddr->has_numeric && saddr->numeric) {
+ ai.ai_flags |= AI_NUMERICHOST | AI_NUMERICSERV;
+ }
ai.ai_family = inet_ai_family_from_address(saddr, &err);
ai.ai_socktype = SOCK_STREAM;
--
2.9.3
- [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23, Daniel P. Berrange, 2017/01/23
- [Qemu-devel] [PULL v1 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress,
Daniel P. Berrange <=
- [Qemu-devel] [PULL v1 2/8] io: stop incrementing reference in qio_task_get_source, Daniel P. Berrange, 2017/01/23
- [Qemu-devel] [PULL v1 4/8] io: add ability to associate an opaque "result" with with a task, Daniel P. Berrange, 2017/01/23
- [Qemu-devel] [PULL v1 3/8] io: fix typo in docs for QIOTask, Daniel P. Berrange, 2017/01/23
- [Qemu-devel] [PULL v1 5/8] io: add ability to associate an error with a task, Daniel P. Berrange, 2017/01/23
- [Qemu-devel] [PULL v1 7/8] io: remove Error parameter from QIOTask thread worker, Daniel P. Berrange, 2017/01/23
- [Qemu-devel] [PULL v1 6/8] io: change the QIOTask callback signature, Daniel P. Berrange, 2017/01/23
- [Qemu-devel] [PULL v1 8/8] io: introduce a DNS resolver API, Daniel P. Berrange, 2017/01/23
- Re: [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23, no-reply, 2017/01/23
- Re: [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23, Peter Maydell, 2017/01/23