qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices
Date: Mon, 23 Jan 2017 10:34:31 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/23/2017 10:30 AM, Pradeep Jagadeesh wrote:
> On 1/23/2017 5:22 PM, Greg Kurz wrote:
>> On Mon, 23 Jan 2017 08:03:18 -0800 (PST)
>> address@hidden wrote:
>>> Hi,
>>>
>>> Your series seems to have some coding style problems. See output
>>> below for
>>> more information:
>>>
>>
> Ya, I observed signoff issue. I have created next version files.
> I will send them tomorrow.
> 
> But, I do not know how to solve the second warning.
> i.e multi line macro issue.

I don't think there is anything to fix there; it is a false positive
from checkpatch.pl (unless you want to dive in to the perl script and
figure out how to relax it to allow that usage, as you are not the first
to have it).  Documenting in the commit message that checkpatch has a
false-positive warning is acceptable.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]