Re: [Qemu-devel] [PATCH v7 15/27] cputlb: introduce tlb_flush_* async work.

[Richard Henderson]

On 01/19/2017 09:04 AM, Alex Bennée wrote:
> +/* NOTE:
> + * If flush_global is true (the usual case), flush all tlb entries.
> + * If flush_global is false, flush (at least) all tlb entries not
> + * marked global.
> + *
> + * Since QEMU doesn't currently implement a global/not-global flag
> + * for tlb entries, at the moment tlb_flush() will also flush all
> + * tlb entries in the flush_global == false case. This is OK because
> + * CPU architectures generally permit an implementation to drop
> + * entries from the TLB at any time, so flushing more entries than
> + * required is only an efficiency issue, not a correctness issue.
> + */
> +void tlb_flush(CPUState *cpu)
> +{

Merge error re-adding the comment for flush_global?

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~