[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF int
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF into trace_ |
Date: |
Tue, 24 Jan 2017 12:20:55 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Eric Blake (address@hidden) wrote:
> On 01/23/2017 03:32 PM, Juan Quintela wrote:
>
> In the subject: s/remained/remaining/
>
> > So we can remove DPRINTF() macro
> >
> > Signed-off-by: Juan Quintela <address@hidden>
> > ---
> > migration/ram.c | 18 ++++--------------
> > migration/trace-events | 4 ++++
> > 2 files changed, 8 insertions(+), 14 deletions(-)
> >
> > diff --git a/migration/ram.c b/migration/ram.c
> > index a1c8089..ef8fadf 100644
> > --- a/migration/ram.c
> > +++ b/migration/ram.c
> > @@ -45,14 +45,6 @@
> > #include "qemu/rcu_queue.h"
> > #include "migration/colo.h"
> >
> > -#ifdef DEBUG_MIGRATION_RAM
> > -#define DPRINTF(fmt, ...) \
> > - do { fprintf(stdout, "migration_ram: " fmt, ## __VA_ARGS__); } while
> > (0)
> > -#else
> > -#define DPRINTF(fmt, ...) \
> > - do { } while (0)
>
> Yay - you're getting rid of the bitrot pattern in this file!
>
> Reviewed-by: Eric Blake <address@hidden>
This change doesn't need the rest of the series so,
queued.
(Fixed up 'remained')
Dave
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 00/17] multifd v3, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF into trace_, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 02/17] migration: create Migration Incoming State at init time, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 03/17] migration: Test for disabled features on reception, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 04/17] migration: Don't create decompression threads if not enabled, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 05/17] migration: Add multifd capability, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 06/17] migration: Create x-multifd-threads parameter, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 07/17] migration: Create x-multifd-group parameter, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 08/17] migration: create multifd migration threads, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 09/17] migration: Start of multiple fd work, Juan Quintela, 2017/01/23