[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qmp: set accurate parameter name for error msg
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] qmp: set accurate parameter name for error msg of device-list-properties |
|
Date: |
Tue, 24 Jan 2017 10:57:52 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/24/2017 04:53 AM, Lin Ma wrote:
> Signed-off-by: Lin Ma <address@hidden>
> ---
The commit message is rather sparse; is there an easy formula for
triggering the error message, to give more context about the change?
> qmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qmp.c b/qmp.c
> index 0028f0b..812db6c 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -531,7 +531,7 @@ DevicePropertyInfoList *qmp_device_list_properties(const
> char *typename,
>
> klass = object_class_dynamic_cast(klass, TYPE_DEVICE);
> if (klass == NULL) {
> - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name", TYPE_DEVICE);
> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename",
> TYPE_DEVICE);
> return NULL;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature