[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] vhost-user: delete chardev on cleanup
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCHv2] vhost-user: delete chardev on cleanup |
Date: |
Tue, 24 Jan 2017 13:16:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/24/2017 01:02 PM, Marc-André Lureau wrote:
> Remove the chardev implicitely when cleaning up the netdev. This
s/implicitely/implicitly/
> prevents from reusing the chardev since it would be in an incorrect
> state with the slave.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1256618
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> net/vhost-user.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/net/vhost-user.c b/net/vhost-user.c
> index 7aff77ee4a..179939f5c1 100644
> --- a/net/vhost-user.c
> +++ b/net/vhost-user.c
> @@ -151,7 +151,10 @@ static void vhost_user_cleanup(NetClientState *nc)
> s->vhost_net = NULL;
> }
> if (nc->queue_index == 0) {
> + CharDriverState *chr = qemu_chr_fe_get_driver(&s->chr);
> +
> qemu_chr_fe_deinit(&s->chr);
> + qemu_chr_delete(chr);
> }
>
> qemu_purge_queued_packets(nc);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature