[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 05/14] apic: save apic_delivered flag
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v7 05/14] apic: save apic_delivered flag |
Date: |
Wed, 25 Jan 2017 14:14:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 25/01/2017 14:01, Pavel Dovgalyuk wrote:
>> From: Paolo Bonzini [mailto:address@hidden
>> On 25/01/2017 12:52, Pavel Dovgalyuk wrote:
>>>> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
>>>> On 24/01/2017 08:17, Pavel Dovgalyuk wrote:
>>>>> This patch implements saving/restoring of static apic_delivered variable.
>>>>>
>>>>> Signed-off-by: Pavel Dovgalyuk <address@hidden>
>>>>> ---
>>>>> hw/intc/apic_common.c | 32 ++++++++++++++++++++++++++++++++
>>>>> include/hw/i386/apic_internal.h | 2 ++
>>>>> 2 files changed, 34 insertions(+)
>>>>>
>>>>> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
>>>>> index d78c885..ac6cc67 100644
>>>>> --- a/hw/intc/apic_common.c
>>>>> +++ b/hw/intc/apic_common.c
>>>>> @@ -384,6 +384,24 @@ static bool apic_common_sipi_needed(void *opaque)
>>>>> return s->wait_for_sipi != 0;
>>>>> }
>>>>>
>>>>> +static bool apic_irq_delivered_needed(void *opaque)
>>>>> +{
>>>>> + return true;
>>>>
>>>> Is it needed for CPUs except the first (or the last?)?
>>>>
>>>
>>> As this is global variable, it is needed only for one CPU.
>>> Do you mean that APIC state is saved for every CPU?
>>
>> Yes, each CPU has its own APIC.
>
> How to link this data to a single CPU?
Since it's global, you only need to migrate it once. You're migrating
the same value many times.
Paolo
[Qemu-devel] [PATCH v7 06/14] replay: don't use rtc clock on loadvm phase, Pavel Dovgalyuk, 2017/01/24
[Qemu-devel] [PATCH v7 08/14] savevm: add public save_vmstate function, Pavel Dovgalyuk, 2017/01/24
[Qemu-devel] [PATCH v7 07/14] integratorcp: adding vmstate for save/restore, Pavel Dovgalyuk, 2017/01/24
[Qemu-devel] [PATCH v7 09/14] replay: save/load initial state, Pavel Dovgalyuk, 2017/01/24
[Qemu-devel] [PATCH v7 10/14] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2017/01/24
[Qemu-devel] [PATCH v7 11/14] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2017/01/24
[Qemu-devel] [PATCH v7 12/14] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2017/01/24
[Qemu-devel] [PATCH v7 13/14] audio: make audio poll timer deterministic, Pavel Dovgalyuk, 2017/01/24
[Qemu-devel] [PATCH v7 14/14] replay: add record/replay for audio passthrough, Pavel Dovgalyuk, 2017/01/24
Re: [Qemu-devel] [PATCH v7 00/14] replay additions, no-reply, 2017/01/24