[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 18/18] hw/pci: disable pci-bridge's shpc by defaul
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v2 18/18] hw/pci: disable pci-bridge's shpc by default |
Date: |
Thu, 26 Jan 2017 18:16:11 +0200 |
From: Marcel Apfelbaum <address@hidden>
The shpc component is optional while ACPI hotplug is used
for hot-plugging PCI devices into a PCI-PCI bridge.
Disabling the shpc by default will make slot 0 usable at boot time
and not only for hot-plug, without loosing any functionality.
Older machines will have shpc enabled for compatibility reasons.
Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
include/hw/compat.h | 4 ++++
hw/pci-bridge/pci_bridge_dev.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/hw/compat.h b/include/hw/compat.h
index 34e9b4a..752a9d7 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -10,6 +10,10 @@
.driver = "fw_cfg_io",\
.property = "x-file-slots",\
.value = stringify(0x10),\
+ },{\
+ .driver = "pci-bridge",\
+ .property = "shpc",\
+ .value = "on",\
},
#define HW_COMPAT_2_7 \
diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c
index 5dbd933..647ad80 100644
--- a/hw/pci-bridge/pci_bridge_dev.c
+++ b/hw/pci-bridge/pci_bridge_dev.c
@@ -163,7 +163,7 @@ static Property pci_bridge_dev_properties[] = {
DEFINE_PROP_ON_OFF_AUTO(PCI_BRIDGE_DEV_PROP_MSI, PCIBridgeDev, msi,
ON_OFF_AUTO_AUTO),
DEFINE_PROP_BIT(PCI_BRIDGE_DEV_PROP_SHPC, PCIBridgeDev, flags,
- PCI_BRIDGE_DEV_F_SHPC_REQ, true),
+ PCI_BRIDGE_DEV_F_SHPC_REQ, false),
DEFINE_PROP_END_OF_LIST(),
};
--
MST
- [Qemu-devel] [PULL v2 08/18] hw/pcie: Introduce a base class for PCI Express Root Ports, (continued)
- [Qemu-devel] [PULL v2 08/18] hw/pcie: Introduce a base class for PCI Express Root Ports, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 09/18] hw/ioh3420: derive from PCI Express Root Port base class, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 11/18] hw/i386: check if nvdimm is enabled before plugging, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 12/18] msix: Follow CODING_STYLE, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 10/18] hw/pcie: Introduce Generic PCI Express Root Port, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 13/18] hcd-xhci: check & correct param before using it, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 15/18] virtio: make virtio_should_notify static, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 16/18] vhost: skip ROM sections, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 17/18] vhost-user: delete chardev on cleanup, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 14/18] pci: Convert msix_init() to Error and fix callers, Michael S. Tsirkin, 2017/01/26
- [Qemu-devel] [PULL v2 18/18] hw/pci: disable pci-bridge's shpc by default,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL v2 00/18] virtio, vhost, pci: fixes, features, Peter Maydell, 2017/01/27