[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] qemu-io: Return non-zero exit code on fa
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] qemu-io: Return non-zero exit code on failure |
Date: |
Mon, 30 Jan 2017 10:44:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/27/2017 09:59 PM, Nir Soffer wrote:
> From: Nir Soffer <address@hidden>
>
> The result of openfile was not checked, leading to failure deep in the
> actual command with confusing error message, and exiting with exit code 0.
>
When posting a series, please ensure that your messages are all marked
In-Reply-To a 0/3 cover letter (it may help if you do 'git config
format.coverletter auto').
> Here is a simple example - trying to read with the wrong format:
>
> $ touch file
> $ qemu-io -f qcow2 -c 'read -P 1 0 1024' file; echo $?
> can't open device file: Image is not in qcow2 format
> no file open, try 'help open'
> 0
>
> With this patch, we fail earlier with exit code 1:
>
> $ ./qemu-io -f qcow2 -c 'read -P 1 0 1024' file; echo $?
> can't open device file: Image is not in qcow2 format
> 1
>
> Signed-off-by: Nir Soffer <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Fam Zheng <address@hidden>
> ---
>
> Changes since v2:
> - Adding missing signed-off-by
> - Fix tests expecting the wrong output
I don't see any tests changed...
>
> qemu-io.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
...in this diffstat. If something really changed in this particular
patch since v2, then you should drop the Reviewed-by lines in order to
make sure I re-review it. Or, if the changes you mention here are to
other patches in the series, then the 0/3 cover letter would have been a
better place to put that information.
>
> diff --git a/qemu-io.c b/qemu-io.c
> index 23a229f..427cbae 100644
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -595,13 +595,17 @@ int main(int argc, char **argv)
> exit(1);
> }
> opts = qemu_opts_to_qdict(qopts, NULL);
> - openfile(NULL, flags, writethrough, opts);
> + if (openfile(NULL, flags, writethrough, opts)) {
> + exit(1);
> + }
> } else {
> if (format) {
> opts = qdict_new();
> qdict_put(opts, "driver", qstring_from_str(format));
> }
> - openfile(argv[optind], flags, writethrough, opts);
> + if (openfile(argv[optind], flags, writethrough, opts)) {
> + exit(1);
> + }
> }
> }
> command_loop();
>
At any rate, I'm happy with this current patch, even if its presentation
in a series is less than ideal, so you can keep my R-b.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature