[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-event
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all" |
Date: |
Mon, 6 Feb 2017 10:36:30 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Sun, Feb 05, 2017 at 12:39:45AM +0200, Lluís Vilanova wrote:
> Fam Zheng writes:
>
> > We install this file to data dir but since 0ab8ed18 it's no longer
> > required by any objects during "make". List it explicitly as a depended
> > target of install and fix the broken "make install" command.
>
> I'm probably wrong, but I remember someone worked on making traces
> self-descriptive, so that simpletrace would no longer need access to the
> generated trace-events-all file.
>
> If the file is really never used, then all stray rules to generate it should
> be
> removed, as well as its installation.
It is used at runtime when analysing a simpletrace file. While it would
be nice if they were self-descriptive, that isn't the case today, so we
must install this file.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|