Re: [Qemu-devel] [PATCH v10 05/23] tcg: add options for enabling MTTCG

[Pranith Kumar]

Hi Alex,

On Tue, Feb 7, 2017 at 5:06 AM, Alex Bennée <address@hidden> wrote:

>
> Pranith Kumar <address@hidden> writes:
>
> >> +
> >> +void qemu_tcg_configure(QemuOpts *opts, Error **errp)
> >> +{
> >> +    const char *t = qemu_opt_get(opts, "thread");
> >> +    if (t) {
> >> +        if (strcmp(t, "multi") == 0) {
> >> +            if (TCG_OVERSIZED_GUEST) {
> >> +                error_setg(errp, "No MTTCG when guest word size >
> hosts");
> >> +            } else {
> >> +                if (!check_tcg_memory_orders_compatible()) {
> >> +                    error_report("Guest requires stronger MO that
> host");
> >>
> >
> > s/MO that host/MO than host/?
>
> Good catch.
>
> >
> > Also, this message is a bit cryptic for end users. How about saying
> "Guest
> > and host architectures are incompatible, you may encounter errors!" or
> > something similar?
>
> "Guest assumes a stronger memory ordering than the host provides, this
> may cause strange/hard to debug errors."
>
> ?
>

s/assumes/expects/?

Otherwise, this statement looks good to me.

Thanks,
-- 
Pranith