[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/22] linux-user: Honor CLONE_SETTLS for openri
From: |
Stafford Horne |
Subject: |
Re: [Qemu-devel] [PATCH 23/22] linux-user: Honor CLONE_SETTLS for openrisc |
Date: |
Fri, 10 Feb 2017 09:44:04 +0900 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
23/22 ?
:)
On Fri, Feb 10, 2017 at 10:01:22AM +1000, Richard Henderson wrote:
> Threads work much better when you set the TLS register.
> This was fixed in the upstream kernel for Linux 4.9.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> linux-user/openrisc/target_cpu.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/linux-user/openrisc/target_cpu.h
> b/linux-user/openrisc/target_cpu.h
> index a21ed1a..f283d96 100644
> --- a/linux-user/openrisc/target_cpu.h
> +++ b/linux-user/openrisc/target_cpu.h
> @@ -30,9 +30,7 @@ static inline void cpu_clone_regs(CPUOpenRISCState *env,
> target_ulong newsp)
>
> static inline void cpu_set_tls(CPUOpenRISCState *env, target_ulong newtls)
> {
> - /* Linux kernel 3.10 does not pay any attention to CLONE_SETTLS
> - * in copy_thread(), so QEMU need not do so either.
> - */
> + env->gpr[10] = newtls;
> }
>
> #endif
> --
> 2.9.3
>
Reviewed-by: Stafford Horne <address@hidden>
- Re: [Qemu-devel] [PATCH 15/22] target/openrisc: Enable trap, csync, msync, psync for user mode, (continued)
- [Qemu-devel] [PATCH 16/22] target/openrisc: Implement msync, Richard Henderson, 2017/02/08
- [Qemu-devel] [PATCH 17/22] target/openrisc: Represent MACHI:MACLO as a single unit, Richard Henderson, 2017/02/08
- [Qemu-devel] [PATCH 18/22] target/openrisc: Implement muld, muldu, macu, msbu, Richard Henderson, 2017/02/08
- [Qemu-devel] [PATCH 19/22] target/openrisc: Fix madd, Richard Henderson, 2017/02/08
- [Qemu-devel] [PATCH 20/22] target/openrisc: Optimize l.jal to next, Richard Henderson, 2017/02/08
- [Qemu-devel] [PATCH 21/22] target/openrisc: Tidy ppc/npc implementation, Richard Henderson, 2017/02/08
- [Qemu-devel] [PATCH 22/22] target/openrisc: Tidy handling of delayed branches, Richard Henderson, 2017/02/08
- [Qemu-devel] [PATCH 23/22] linux-user: Honor CLONE_SETTLS for openrisc, Richard Henderson, 2017/02/09
- Re: [Qemu-devel] [PATCH 23/22] linux-user: Honor CLONE_SETTLS for openrisc,
Stafford Horne <=
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, G 3, 2017/02/09
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, Stafford Horne, 2017/02/09
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, Richard Henderson, 2017/02/13
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, Programmingkid, 2017/02/13
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, Stafford Horne, 2017/02/15
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, Stafford Horne, 2017/02/20
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, Stafford Horne, 2017/02/23
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, G 3, 2017/02/23
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, Stafford Horne, 2017/02/25
- Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates, Richard Henderson, 2017/02/23