[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/10] PC: Support dynamic sysbus on pc_i440f
From: |
Ben Warren |
Subject: |
Re: [Qemu-devel] [PATCH v5 08/10] PC: Support dynamic sysbus on pc_i440fx |
Date: |
Sun, 12 Feb 2017 16:32:08 -0800 |
Hi
> On Feb 12, 2017, at 11:55 AM, Marcel Apfelbaum <address@hidden> wrote:
>
> On 02/06/2017 06:31 PM, Michael S. Tsirkin wrote:
>> On Sun, Feb 05, 2017 at 01:12:03AM -0800, address@hidden wrote:
>>> From: Ben Warren <address@hidden>
>>>
>>> This allows pc_i440fx-based machines to add new devices such as
>>> VM Generation ID directly to the sysbus.
>>>
>>> Signed-off-by: Ben Warren <address@hidden>
>>
>
> Hi,
>
>> Only point is, we might have to add more flags like
>> cannot_instantiate_with_device_add_yet
>> to a bunch of devices.
>>
>> Marcel, you did a similar thing for q35, can you
>> take a look here as well pls?
>>
>
> The change is a must because the new vmgenid device
> is a sysbus device and QEMU will not allow it without
> marking explicitly that i440fx supports sysbus device.
>
As recommended by Igor, I was able to make the vmgenid work with DeviceClass as
parent (i.e. not on sysbus), so this work can be deferred until it’s really
needed. The next patch set (hopefully posted tonight) will drop this patch.
> As you already mentioned, we need to make sure that
> all sysbus devices that can be added to the PC machines
> are marked with "cannot_instantiate_with_device_add_yet".
>
> Sadly I see no easy way, but going manually over each one...
>
> Thanks,
> Marcel
>
—Ben
>>> ---
>>> hw/i386/pc_piix.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>>> index 9f102aa..c8ad99c 100644
>>> --- a/hw/i386/pc_piix.c
>>> +++ b/hw/i386/pc_piix.c
>>> @@ -435,6 +435,7 @@ static void pc_i440fx_machine_options(MachineClass *m)
>>> m->hot_add_cpu = pc_hot_add_cpu;
>>> m->default_machine_opts = "firmware=bios-256k.bin";
>>> m->default_display = "std";
>>> + m->has_dynamic_sysbus = true;
>>> }
>>>
>>> static void pc_i440fx_2_9_machine_options(MachineClass *m)
>>> --
>>> 2.7.4
>>
>
smime.p7s
Description: S/MIME cryptographic signature
- Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support, (continued)
- Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support, Michael S. Tsirkin, 2017/02/09
- Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support, Laszlo Ersek, 2017/02/09
- Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support, Ben Warren, 2017/02/09
- Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support, Laszlo Ersek, 2017/02/09
- Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support, Ben Warren, 2017/02/09
- Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support, Igor Mammedov, 2017/02/10
Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support, Laszlo Ersek, 2017/02/08
[Qemu-devel] [PATCH v5 08/10] PC: Support dynamic sysbus on pc_i440fx, ben, 2017/02/05
Re: [Qemu-devel] [PATCH v5 08/10] PC: Support dynamic sysbus on pc_i440fx, Igor Mammedov, 2017/02/07
[Qemu-devel] [PATCH v5 06/10] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands, ben, 2017/02/05
[Qemu-devel] [PATCH v5 07/10] qmp/hmp: add set-vm-generation-id commands, ben, 2017/02/05
[Qemu-devel] [PATCH v5 09/10] tests: Move reusable ACPI macros into a new header file, ben, 2017/02/05
[Qemu-devel] [PATCH v5 10/10] tests: Add unit tests for the VM Generation ID feature, ben, 2017/02/05
Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Laszlo Ersek, 2017/02/10