[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH V2] qemu-img: make convert async
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [RFC PATCH V2] qemu-img: make convert async |
Date: |
Mon, 13 Feb 2017 08:07:26 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC PATCH V2] qemu-img: make convert async
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
- [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
b4ff8af qemu-img: make convert async
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qemu-img: make convert async...
ERROR: do not use C99 // comments
#60: FILE: qemu-img.c:1458:
+//XXX: this should be a cmdline parameter
WARNING: line over 80 characters
#113: FILE: qemu-img.c:1586:
+ ret = blk_co_preadv(blk, (sector_num - s->src_cur_offset) <<
BDRV_SECTOR_BITS,
ERROR: line over 90 characters
#148: FILE: qemu-img.c:1633:
+ n << BDRV_SECTOR_BITS, qiov,
BDRV_REQ_WRITE_COMPRESSED);
WARNING: line over 80 characters
#170: FILE: qemu-img.c:1660:
+ ret = blk_co_pwrite_zeroes(s->target, sector_num <<
BDRV_SECTOR_BITS,
ERROR: do not use assignment in if condition
#195: FILE: qemu-img.c:1690:
+ if ((elt2 = QSIMPLEQ_FIRST(&s->queue))) {
ERROR: do not use C99 // comments
#215: FILE: qemu-img.c:1710:
+ //~ //XXX: in-order write on/off could be a switch
WARNING: line over 80 characters
#223: FILE: qemu-img.c:1718:
+ ret = convert_write(s, elt->sector_num, elt->nb_sectors, buf, &qiov,
elt->status);
total: 4 errors, 3 warnings, 293 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden