[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/5] net: e1000e: fix dead code in e1000e_write_packe
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 2/5] net: e1000e: fix dead code in e1000e_write_packet_to_guest |
Date: |
Wed, 15 Feb 2017 11:53:19 +0800 |
From: Paolo Bonzini <address@hidden>
Because is_first is declared inside a loop, it is always true. The store
is dead, and so is the "else" branch of "if (is_first)". is_last is
okay though.
Reported by Coverity.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Dmitry Fleytman <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/e1000e_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 2b11499..c99e2fb 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -1507,6 +1507,7 @@ e1000e_write_packet_to_guest(E1000ECore *core, struct
NetRxPkt *pkt,
const E1000E_RingInfo *rxi;
size_t ps_hdr_len = 0;
bool do_ps = e1000e_do_ps(core, pkt, &ps_hdr_len);
+ bool is_first = true;
rxi = rxr->i;
@@ -1514,7 +1515,6 @@ e1000e_write_packet_to_guest(E1000ECore *core, struct
NetRxPkt *pkt,
hwaddr ba[MAX_PS_BUFFERS];
e1000e_ba_state bastate = { { 0 } };
bool is_last = false;
- bool is_first = true;
desc_size = total_size - desc_offset;
--
2.7.4
- [Qemu-devel] [PULL 0/5] Net patches, Jason Wang, 2017/02/14
- [Qemu-devel] [PULL 1/5] net: Mark 'vlan' parameter as deprecated, Jason Wang, 2017/02/14
- [Qemu-devel] [PULL 2/5] net: e1000e: fix dead code in e1000e_write_packet_to_guest,
Jason Wang <=
- [Qemu-devel] [PULL 3/5] colo-compare: sort TCP packet queue by sequence number, Jason Wang, 2017/02/14
- [Qemu-devel] [PULL 4/5] net: imx: limit buffer descriptor count, Jason Wang, 2017/02/14
- [Qemu-devel] [PULL 5/5] net: e1000e: fix an infinite loop issue, Jason Wang, 2017/02/14
- Re: [Qemu-devel] [PULL 0/5] Net patches, Peter Maydell, 2017/02/16