[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] audio: make audio poll timer deterministic
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3] audio: make audio poll timer deterministic |
Date: |
Thu, 16 Feb 2017 16:12:30 +0100 |
On Di, 2017-02-14 at 12:59 +0100, Paolo Bonzini wrote:
>
> On 14/02/2017 08:15, Pavel Dovgalyuk wrote:
> > This patch changes resetting strategy of the audio polling timer.
> > It does not change expiration time if the timer is already set.
> > This patch is needed to make this timer deterministic and to use execution
> > record/replay for audio devices.
> >
> > audio_reset_timer is used in the function audio_vm_change_state_handler.
> > Therefore every time VM is stopped or restarted the timer will be reset
> > to new timeout. Virtual clock does not proceed while VM is stopped.
> > Therefore there is no need in resetting the timeout when VM restarts.
> >
> > v2: updated commit message
> > v3: now using timer_mod_anticipate function (as suggested by Yurii
> > Zubrytskyi)
>
> Gerd, feel free to pick either v2 or v3.
Picked up v3 now.
thanks,
Gerd