Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

[Vladimir Sementsov-Ogievskiy]

16.02.2017 14:49, Kevin Wolf wrote:
> Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben:
> > Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > Auto loading bitmaps are bitmaps stored in the disk image, which should
> > > be loaded when the image is opened and become BdrvDirtyBitmaps for the
> > > corresponding drive.
> > >
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > > Reviewed-by: John Snow <address@hidden>
> > > Reviewed-by: Max Reitz <address@hidden>
> > Why do we need a new BlockDriver callback and special code for it in
> > bdrv_open_common()? The callback is only ever called immediately after
> > .bdrv_open/.bdrv_file_open, so can't the drivers just do this internally
> > in their .bdrv_open implementation? Even more so because qcow2 is the
> > only driver that supports this callback.
> Actually, don't we have to call this in qcow2_invalidate_cache()?
> Currently, I think, after a migration, the autoload bitmaps aren't
> loaded.
>
> By moving the qcow2_load_autoloading_dirty_bitmaps() call to
> qcow2_open(), this would be fixed.
>
> Kevin

Bitmap should not be reloaded on any intermediate qcow2-open's, reopens, 
etc. It should be loaded once, on bdrv_open, to not create extra 
collisions (between in-memory bitmap and it's stored version). That was 
the idea.

For bitmaps migration there are separate series, we shouldn't load 
bitmap from file on migration, as it's version in the file is outdated.

,

--
Best regards,
Vladimir