Re: [Qemu-devel] [PATCH v8 0/8] Add support for VM Generation ID

[Laszlo Ersek]

On 02/20/17 16:45, Kevin O'Connor wrote:
> On Mon, Feb 20, 2017 at 04:41:38PM +0100, Laszlo Ersek wrote:
>> On 02/20/17 15:57, Igor Mammedov wrote:
>>> On Thu, 16 Feb 2017 15:15:32 -0800
>>> address@hidden wrote:
>>>
>>>> From: Ben Warren <address@hidden>
>>>>
>>>> This patch set adds support for passing a GUID to Windows guests.  It is a
>>>> re-implementation of previous patch sets written by Igor Mammedov et al, 
>>>> but
>>>> this time passing the GUID data as a fw_cfg blob.
>>>>
>>>> This patch set has dependencies on new guest functionality, in particular 
>>>> the
>>>> support for a new linker-loader command and the ability to write back data
>>>> to QEMU over a DMA link.  Work is in flight in both SeaBIOS and OVMF to 
>>>> support this.
>>>>
>>>> v7->v8:
>>>>     - Rebased to top of tree.
>>>>     - Fixed two small bugs in "write pointer" function
>>>>     - minor re-ordering of data in patches
>>>>     - Fixed unit test by adding delays/retries to reading RSDP table
>>> Michael,
>>>
>>> series looks good for merging.
>>> Patch
>>>  [PATCH v8 7/8] tests: Add unit tests for the VM  Generation ID feature
>>> needs updated seabios blob to make 'make check' happy
>>> so we probably should merge/update seabios first
>>>   [PATCH v5 0/5] QEMU: Add capability to write back fw_cfg address to QEMU
>>>
>>> CCing Gerd and Kevin.
>>>
>>
>> That's sort of a circular dependency, as Kevin generally prefers to
>> merge SeaBIOS patches once the underlying QEMU code has been committed :)
>>
>> For a total ordering, all QEMU patches except v8 7/8 could be merged in
>> QEMU, then the v5 SeaBIOS patches could be merged, then Gerd could
>> refresh the bundled SeaBIOS binaries, then QEMU patch v8 7/8 could be
>> merged.
>>
>> I'm not actually suggesting that though, given that the soft freeze is
>> in about a week.
>>
>> Kevin, can you please make an exception this time and merge the SeaBIOS
>> patches ahead of the QEMU patches?
> 
> Yes.

Thank you!

Ben, Igor or Michael -- can one of you please add a paragraph on VMGENID
to <http://wiki.qemu-project.org/ChangeLog/2.9>, later on?

(Ben, if you don't have an account yet, I think Stefan (CC'd) can give
you one.)

Thanks!
Laszlo

> 
> Gerd - are you planning to backport this series to the stable branch?
> 
> -Kevin
>