[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 25/29] 9pfs: local: symlink: don't follow symlin
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 25/29] 9pfs: local: symlink: don't follow symlinks |
Date: |
Thu, 23 Feb 2017 15:15:40 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Mon, Feb 20, 2017 at 03:42:34PM +0100, Greg Kurz wrote:
> The local_symlink() callback is vulnerable to symlink attacks because it
> calls:
>
> (1) symlink() which follows symbolic links for all path elements but the
> rightmost one
> (2) open(O_NOFOLLOW) which follows symbolic links for all path elements but
> the rightmost one
> (3) local_set_xattr()->setxattr() which follows symbolic links for all
> path elements
> (4) local_set_mapped_file_attr() which calls in turn local_fopen() and
> mkdir(), both functions following symbolic links for all path
> elements but the rightmost one
>
> This patch converts local_symlink() to rely on opendir_nofollow() and
> symlinkat() to fix (1), openat(O_NOFOLLOW) to fix (2), as well as
> local_set_xattrat() and local_set_mapped_file_attrat() to fix (3) and
> (4) respectively.
>
> This partly fixes CVE-2016-9602.
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> hw/9pfs/9p-local.c | 81
> ++++++++++++++++------------------------------------
> 1 file changed, 25 insertions(+), 56 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH 20/29] 9pfs: local: rename: use renameat, (continued)
- [Qemu-devel] [PATCH 21/29] 9pfs: local: improve error handling in link op, Greg Kurz, 2017/02/20
- [Qemu-devel] [PATCH 22/29] 9pfs: local: link: don't follow symlinks, Greg Kurz, 2017/02/20
- [Qemu-devel] [PATCH 23/29] 9pfs: local: chmod: don't follow symlinks, Greg Kurz, 2017/02/20
- [Qemu-devel] [PATCH 24/29] 9pfs: local: chown: don't follow symlinks, Greg Kurz, 2017/02/20
- [Qemu-devel] [PATCH 25/29] 9pfs: local: symlink: don't follow symlinks, Greg Kurz, 2017/02/20
- Re: [Qemu-devel] [PATCH 25/29] 9pfs: local: symlink: don't follow symlinks,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 26/29] 9pfs: local: mknod: don't follow symlinks, Greg Kurz, 2017/02/20
- [Qemu-devel] [PATCH 27/29] 9pfs: local: mkdir: don't follow symlinks, Greg Kurz, 2017/02/20
- [Qemu-devel] [PATCH 28/29] 9pfs: local: open2: don't follow symlinks, Greg Kurz, 2017/02/20
- [Qemu-devel] [PATCH 29/29] 9pfs: local: drop unused code, Greg Kurz, 2017/02/20