[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/21] qapi: Improve a QObject input visitor err
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 09/21] qapi: Improve a QObject input visitor error message |
Date: |
Sat, 25 Feb 2017 09:44:28 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/23/2017 03:45 PM, Markus Armbruster wrote:
> The QObject input visitor has three error message formats:
>
> * Parameter '%s' is missing
> * "Invalid parameter type for '%s', expected: %s"
> * "QMP input object member '%s' is unexpected"
>
> The '%s' are member names (or "null", but I'll fix that later).
>
> The last error message calls the thing "QMP input object member"
> instead of "parameter". Misleading when the visitor is used on
> QObjects that don't come from QMP. Change it to "Parameter '%s' is
> unexpected".
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qapi/qobject-input-visitor.c | 3 +--
> tests/test-qga.c | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/21] qapi: QMP dispatch and input visitor work, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 09/21] qapi: Improve a QObject input visitor error message, Markus Armbruster, 2017/02/23
- Re: [Qemu-devel] [PATCH 09/21] qapi: Improve a QObject input visitor error message,
Eric Blake <=
- [Qemu-devel] [PATCH 04/21] qmp: Dumb down how we run QMP command registration, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 03/21] qmp-test: New, covering basic QMP protocol, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 01/21] qga: Fix crash on non-dictionary QMP argument, Markus Armbruster, 2017/02/23