[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/16] exec: ram_block_discard_range
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/16] exec: ram_block_discard_range |
Date: |
Sun, 26 Feb 2017 20:23:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 24/02/2017 19:28, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Create ram_block_discard_range in exec.c to replace
> postcopy_ram_discard_range and most of ram_discard_range.
>
> Those two routines are a bit of a weird combination, and
> ram_discard_range is about to get more complex for hugepages.
> It's OS dependent code (so shouldn't be in migration/ram.c) but
> it needs quite a bit of the innards of RAMBlock so doesn't belong in
> the os*.c.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Juan Quintela <address@hidden>
> ---
> exec.c | 54
> ++++++++++++++++++++++++++++++++++++++++
> include/exec/cpu-common.h | 1 +
> include/migration/postcopy-ram.h | 7 ------
> migration/postcopy-ram.c | 30 +---------------------
> migration/ram.c | 24 +++---------------
> migration/trace-events | 2 +-
> 6 files changed, 60 insertions(+), 58 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 865a1e8..ddbc314 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -45,6 +45,7 @@
> #include "exec/address-spaces.h"
> #include "sysemu/xen-mapcache.h"
> #include "trace-root.h"
> +
> #endif
It seems a blank line has "migrated" here from PATCH v2 11/16. ;)
Reviewed-by: Laurent Vivier <address@hidden>
- [Qemu-devel] [PATCH v3 00/16] Postcopy: Hugepage support, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 02/16] postcopy: Transmit and compare individual page sizes, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 01/16] postcopy: Transmit ram size summary word, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 03/16] postcopy: Chunk discards for hugepages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 04/16] exec: ram_block_discard_range, Dr. David Alan Gilbert (git), 2017/02/24
- Re: [Qemu-devel] [PATCH v3 04/16] exec: ram_block_discard_range,
Laurent Vivier <=
- [Qemu-devel] [PATCH v3 06/16] postcopy: Record largest page size, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 08/16] postcopy: Use temporary for placing zero huge pages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 05/16] postcopy: enhance ram_block_discard_range for hugepages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 07/16] postcopy: Plumb pagesize down into place helpers, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 10/16] postcopy: Mask fault addresses to huge page boundary, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 09/16] postcopy: Load huge pages in one go, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 12/16] postcopy: Allow hugepages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 11/16] postcopy: Send whole huge pages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 14/16] postcopy: Check for userfault+hugepage feature, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 13/16] postcopy: Update userfaultfd.h header, Dr. David Alan Gilbert (git), 2017/02/24