[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 19/30] tests: fix i440fx-test leaks
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 19/30] tests: fix i440fx-test leaks |
Date: |
Mon, 27 Feb 2017 15:05:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/i440fx-test.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index da2d5a53f0..e9d05c87d1 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -134,6 +134,8 @@ static void test_i440fx_defaults(gconstpointer opaque)
> /* 3.2.26 */
> g_assert_cmpint(qpci_config_readb(dev, 0x93), ==, 0x00); /* TRC */
>
> + g_free(dev);
> + qpci_free_pc(bus);
> qtest_end();
> }
>
> @@ -270,6 +272,9 @@ static void test_i440fx_pam(gconstpointer opaque)
> /* Verify the area is not our new mask */
> g_assert(!verify_area(pam_area[i].start, pam_area[i].end, 0x82));
> }
> +
> + g_free(dev);
> + qpci_free_pc(bus);
> qtest_end();
> }
Reviewed-by: Markus Armbruster <address@hidden>
- Re: [Qemu-devel] [PATCH v2 14/30] tests: fix ipmi-bt-test leak, (continued)
- [Qemu-devel] [PATCH v2 13/30] tests: fix ipmi-kcs-test leak, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 15/30] pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 16/30] tests: fix eepro100-test leak, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 17/30] tests: fix tco-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 18/30] tests: fix e1000-test leak, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 19/30] tests: fix i440fx-test leaks, Marc-André Lureau, 2017/02/21
- Re: [Qemu-devel] [PATCH v2 19/30] tests: fix i440fx-test leaks,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 20/30] tests: fix e1000e leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 21/30] tests: fix virtio-scsi-test leak, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 22/30] tests: fix virtio-9p-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 23/30] bus: do not unref hotplug handler, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 24/30] usb: replace handle_destroy with unrealize, Marc-André Lureau, 2017/02/21