[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 25/44] commit: Use real permissions in commit
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v3 25/44] commit: Use real permissions in commit block job |
Date: |
Tue, 28 Feb 2017 16:29:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
On 28.02.2017 13:54, Kevin Wolf wrote:
> This is probably one of the most interesting conversions to the new
> op blocker system because a commit block job intentionally leaves some
> intermediate block nodes in the backing chain that aren't valid on their
> own any more; only the whole chain together results in a valid view.
>
> In order to provide the 'consistent read' permission to the parents of
> the 'top' node of the commit job, a new filter block driver is inserted
> above 'top' which doesn't require 'consistent read' on its backing
> chain. Subsequently, the commit job can block 'consistent read' on all
> intermediate nodes without causing a conflict.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/commit.c | 113
> ++++++++++++++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 95 insertions(+), 18 deletions(-)
Thanks for the comment change!
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 18/44] hw/block: Request permissions, (continued)
- [Qemu-devel] [PATCH v3 18/44] hw/block: Request permissions, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 21/44] block: Add BdrvChildRole.get_parent_desc(), Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 19/44] hw/block: Introduce share-rw qdev property, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 23/44] block: Add BdrvChildRole.stay_at_node, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 22/44] block: Include details on permission errors in message, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 20/44] blockjob: Add permissions to block_job_create(), Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 26/44] commit: Use real permissions for HMP 'commit', Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 25/44] commit: Use real permissions in commit block job, Kevin Wolf, 2017/02/28
- Re: [Qemu-devel] [PATCH v3 25/44] commit: Use real permissions in commit block job,
Max Reitz <=
- [Qemu-devel] [PATCH v3 24/44] blockjob: Add permissions to block_job_add_bdrv(), Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 27/44] backup: Use real permissions in backup block job, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 28/44] block: Fix pending requests check in bdrv_append(), Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 29/44] block: BdrvChildRole.attach/detach() callbacks, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 30/44] block: Allow backing file links in change_parent_backing_link(), Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 31/44] blockjob: Factor out block_job_remove_all_bdrv(), Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 33/44] stream: Use real permissions in streaming block job, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH v3 32/44] mirror: Use real permissions in mirror/active commit block job, Kevin Wolf, 2017/02/28