Re: [Qemu-devel] [PATCH v2 22/26] test-qobject-input-visitor: Cover missing nested struct member

[Eric Blake]

On 02/26/2017 03:43 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  tests/test-qobject-input-visitor.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/test-qobject-input-visitor.c 
> b/tests/test-qobject-input-visitor.c
> index 10c15c4..6e04736 100644
> --- a/tests/test-qobject-input-visitor.c
> +++ b/tests/test-qobject-input-visitor.c
> @@ -894,7 +894,7 @@ static void 
> test_visitor_in_fail_struct_missing(TestInputVisitorData *data,
>      char *str;
>      double dbl;
>  
> -    v = visitor_input_test_init(data, "{}");
> +    v = visitor_input_test_init(data, "{ 'sub': [ {} ] }");
>      visit_start_struct(v, NULL, NULL, 0, &error_abort);
>      visit_start_struct(v, "struct", NULL, 0, &err);
>      error_free_or_abort(&err);
> @@ -920,6 +920,11 @@ static void 
> test_visitor_in_fail_struct_missing(TestInputVisitorData *data,
>      error_free_or_abort(&err);
>      visit_type_null(v, "null", &err);
>      error_free_or_abort(&err);
> +    visit_start_list(v, "sub", NULL, 0, &error_abort);
> +    visit_start_struct(v, NULL, NULL, 0, &error_abort);
> +    visit_type_int(v, "i64", &i64, &err);
> +    error_free_or_abort(&err);
> +    visit_end_struct(v, NULL);
>      visit_end_struct(v, NULL);

Missing a visit_end_list, no?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature