[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Bugfix: Handle error if VM Generation ID device
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] Bugfix: Handle error if VM Generation ID device not present |
Date: |
Thu, 2 Mar 2017 23:45:49 +0200 |
On Thu, Mar 02, 2017 at 03:41:33PM -0600, Eric Blake wrote:
> On 03/02/2017 03:36 PM, address@hidden wrote:
> > From: Ben Warren <address@hidden>
> >
> > This was crashing due to NULL-pointer dereference
> >
> > QMP Test case:
> > ==============
> >
> > (QEMU) query-vm-generation-id
> > {"error": {"class": "GenericError", "desc": "VM Generation ID device not
> > found"}}
> >
> > HMP Test case:
> > ==============
> > virsh # qemu-monitor-command --hmp 3 info vm-generation-id
> > VM Generation ID device not found
> >
> > Signed-off-by: Ben Warren <address@hidden>
> > ---
> > hmp.c | 4 +++-
> > hw/acpi/vmgenid.c | 1 +
> > 2 files changed, 4 insertions(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> However, hw/acpi/vmgenid.c is not part of the tree yet, so it may be
> better to just respin the pull request to incorporate this into the
> problematic patch that introduced the problem, rather than needing a
> followup patch.
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
The issue seems minor enough.
I don't plan to re-spin unless there are more issues.
--
MST